Merge branch 'main' into deno_graph_load_perf

cli/tools/registry/graph.rs

@@ -32,25 +32,45 @@ impl GraphDiagnosticsCollector {
     }
   }
 
-            // check for a missing version constraint
-            if let Ok(jsr_req_ref) =
-              JsrPackageReqReference::from_specifier(&resolution.specifier)
-            {
-              if jsr_req_ref.req().version_req.version_text() == "*" {
-                let maybe_version = graph
-                  .packages
-                  .mappings()
-                  .get(jsr_req_ref.req())
-                  .map(|nv| nv.version.clone());
-                diagnostics_collector.push(
-                  PublishDiagnostic::MissingConstraint {
-                    specifier: resolution.specifier.clone(),
-                    specifier_text: specifier_text.to_string(),
-                    resolved_version: maybe_version,
-                    text_info: SourceTextInfo::new(source_text.clone()),
-                    referrer: resolution.range.clone(),
-                  },
-                );
+  pub fn collect_diagnostics_for_graph(
+    &self,
+    graph: &ModuleGraph,
+    diagnostics_collector: &PublishDiagnosticsCollector,
+  ) -> Result<(), AnyError> {
+    let mut visited = HashSet::new();
+    let mut skip_specifiers: HashSet<Url> = HashSet::new();
+
+    let mut collect_if_invalid =
+      |skip_specifiers: &mut HashSet<Url>,
+       source_text: &Arc<str>,
+       specifier_text: &str,
+       resolution: &ResolutionResolved| {
+        if visited.insert(resolution.specifier.clone()) {
+          match resolution.specifier.scheme() {
+            "file" | "data" | "node" => {}
+            "jsr" => {
+              skip_specifiers.insert(resolution.specifier.clone());
+
+              // check for a missing version constraint
+              if let Ok(jsr_req_ref) =
+                JsrPackageReqReference::from_specifier(&resolution.specifier)
+              {
+                if jsr_req_ref.req().version_req.version_text() == "*" {
+                  let maybe_version = graph
+                    .packages
+                    .mappings()
+                    .get(jsr_req_ref.req())
+                    .map(|nv| nv.version.clone());
+                  diagnostics_collector.push(
+                    PublishDiagnostic::MissingConstraint {
+                      specifier: resolution.specifier.clone(),
+                      specifier_text: specifier_text.to_string(),
+                      resolved_version: maybe_version,
+                      text_info: SourceTextInfo::new(source_text.clone()),
+                      referrer: resolution.range.clone(),
+                    },
+                  );
+                }
               }
             }
             "npm" => {