Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: skip npm install if graph has no new packages #24017

Merged
merged 24 commits into from
May 28, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 28, 2024

old is main, deno_new is #23979, target/release/deno is this PR

Benchmark 1: ../../deno/target/release/deno run -A repro.ts
  Time (mean ± σ):     323.7 ms ±   4.3 ms    [User: 245.3 ms, System: 86.2 ms]
  Range (min  max):   319.4 ms  330.7 ms    10 runs
 
Benchmark 2: ../../deno/deno_new run -A repro.ts
  Time (mean ± σ):     450.2 ms ±   5.4 ms    [User: 365.8 ms, System: 108.6 ms]
  Range (min  max):   443.7 ms  458.3 ms    10 runs
 
Benchmark 3: ../../deno/deno_old run -A repro.ts
  Time (mean ± σ):     538.5 ms ±   7.2 ms    [User: 445.9 ms, System: 103.2 ms]
  Range (min  max):   531.7 ms  552.3 ms    10 runs
 
Summary
  ../../deno/target/release/deno run -A repro.ts ran
    1.39 ± 0.02 times faster than ../../deno/deno_new run -A repro.ts
    1.66 ± 0.03 times faster than ../../deno/deno_old run -A repro.ts

Still more to come. We can skip building the entire graph in this case, but right now I'm having it still do it so that we get rid of these other perf issues.

Waiting on #23979

@dsherret dsherret marked this pull request as ready for review May 28, 2024 18:59
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, impressive improvements

@dsherret dsherret merged commit 69da5d8 into denoland:main May 28, 2024
17 checks passed
@dsherret dsherret deleted the deno_graph_load_perf2 branch May 28, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants