Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/http): flush gzip streaming response #23991

Merged
merged 10 commits into from
May 28, 2024
Merged

fix(ext/http): flush gzip streaming response #23991

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ba6310a
add TODOs after talking with Matt
bartlomieju May 22, 2024
ea10ff1
Merge branch 'main' into flush_streaming_response_on_timeout
bartlomieju May 27, 2024
646fdeb
add repro
bartlomieju May 27, 2024
c42aa90
Use Z_FLUSH_SYNC for streaming gzip response chunks
littledivy May 27, 2024
73c88bf
Cleanup
littledivy May 27, 2024
10dd5d9
Cleanup 2
littledivy May 27, 2024
3acae8d
Cleanup
littledivy May 27, 2024
789844a
Merge branch 'main' into flush_streaming_response_on_timeout
littledivy May 27, 2024
9e7cd45
Add test
littledivy May 28, 2024
817fec4
Fix
littledivy May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@littledivy
littledivy committed May 27, 2024
commit 73c88bf2372e1dda71c4cf58eb0fdc624a92854a
3 changes: 0 additions & 3 deletions ext/http/response_body.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ impl PollFrame for tokio::sync::mpsc::Receiver<BufView> {
enum GZipState {
Header,
Streaming,
// TODO: add FlushingIdle or PendingFlush for in the middle.
Flushing,
Trailer,
EndOfStream,
Expand Down Expand Up @@ -373,7 +372,6 @@ impl PollFrame for GZipResponseStream {
if let Some(partial) = this.partial.take() {
ResponseStreamResult::NonEmptyBuf(partial)
} else {
// TODO: If we get "flush" here we should flush the gzip stream
ready!(Pin::new(&mut this.underlying).poll_frame(cx))
}
}
Expand Down Expand Up @@ -409,7 +407,6 @@ impl PollFrame for GZipResponseStream {
input.advance_cursor(len_in);
this.partial = Some(input);
}

res
}
};
Expand Down
Loading