Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/http): fix crash in dropped Deno.serve requests #21252

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Nov 18, 2023

Fixes #21250

We were attempting to recycle dropped resource responses too early.

mmastrac added a commit to mmastrac/deno that referenced this pull request Nov 18, 2023
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mmastrac mmastrac merged commit 679b7bb into denoland:main Nov 18, 2023
13 checks passed
mmastrac added a commit that referenced this pull request Nov 18, 2023
Fixes #21250

We were attempting to recycle dropped resource responses too early.
zifeo pushed a commit to metatypedev/deno that referenced this pull request Nov 22, 2023
Fixes denoland#21250

We were attempting to recycle dropped resource responses too early.
bartlomieju pushed a commit that referenced this pull request Nov 24, 2023
Fixes #21250

We were attempting to recycle dropped resource responses too early.
@justjavac justjavac mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno panickes serving some HTTP requests with Deno.serve().
2 participants