-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deno panickes serving some HTTP requests with Deno.serve(). #21250
Comments
@oscarotero Thanks for the report. Does your response handler return a stream in this case? (ie: a file, or a streaming response from fresh, etc) Is it happening when you refresh in the browser? |
I can reproduce this by dropping a TCP connection before the response is returned. |
@mmastrac I don't know. I'm serving a complete site with html files, images, etc. I couldn't tell which of these responses causes the panick. |
mmastrac
added a commit
that referenced
this issue
Nov 18, 2023
Fixes #21250 We were attempting to recycle dropped resource responses too early.
mmastrac
added a commit
that referenced
this issue
Nov 18, 2023
Fixes #21250 We were attempting to recycle dropped resource responses too early.
zifeo
pushed a commit
to metatypedev/deno
that referenced
this issue
Nov 22, 2023
Fixes denoland#21250 We were attempting to recycle dropped resource responses too early.
bartlomieju
pushed a commit
that referenced
this issue
Nov 24, 2023
Fixes #21250 We were attempting to recycle dropped resource responses too early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It happens with Deno 1.38.2 (macOS)
Deno 1.38.1 works fine.
This is the full backtrace:
The text was updated successfully, but these errors were encountered: