Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ext/web): use a non-resource stream for textDecoderStreamCleansUpOnCancel #21181

Merged
merged 4 commits into from
Nov 13, 2023
+16 −4
Merged

chore(ext/web): use a non-resource stream for textDecoderStreamCleansUpOnCancel #21181

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bfbfb5
chore(ext/web): ignore op sanitizer for textDecoderStreamCleansUpOnCa…
mmastrac Nov 13, 2023
06470bc
Use a ReadableStream rather than a resource for this test
mmastrac Nov 13, 2023
2bdb739
No need for a timer
mmastrac Nov 13, 2023
1fb8d0f
Revert whitespace change
mmastrac Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(ext/web): ignore op sanitizer for textDecoderStreamCleansUpOnCa… 
…ncel
  • Loading branch information
@mmastrac
mmastrac committed Nov 13, 2023
commit 3bfbfb58055151f3cc9fb70f632dabff238fe8b7
7 changes: 6 additions & 1 deletion cli/tests/unit/text_encoding_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,12 @@ Deno.test(function binaryEncode() {
});

Deno.test(
{ permissions: { read: true } },
{
permissions: { read: true },
// TODO(mmastrac): readableStreamForRid doesn't guarantee cancellation of ops, so we may be left with a
// dangling read op that triggers the sanitizer.
sanitizeOps: false,
},
async function textDecoderStreamCleansUpOnCancel() {
const filename = "cli/tests/testdata/assets/hello.txt";
const file = await Deno.open(filename);
Expand Down