chore(ext/web): use a non-resource stream for textDecoderStreamCleansUpOnCancel #21181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
approved these changes
Nov 13, 2023
|
Why do we need to ignore sanitizers here? Won't this cause interference with other tests? That seems like an actual problem. |
Actually this might be a good point... Maybe we can rewrite this using a non-resource stream. |
auto-merge was automatically disabled
November 13, 2023 17:06
Pull request was converted to draft
mmastrac
changed the title
|
Just went ahead and merged this one because it's flaking a lot of builds. |
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
…UpOnCancel (denoland#21181) Follow-up fix to denoland#21074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up fix to #21074