Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): update tsconfig after refreshing settings on init #21170

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #21167.

@irbull
Copy link
Contributor

irbull commented Nov 12, 2023

I pulled down the change-set and calling ls.update_tsconfig does this fix the problem. Thanks!

I'm not sure I understand how the changes to the tests are related to this issue and the commit message didn't provide any hints.

@nayeemrmn nayeemrmn merged commit 55e0483 into denoland:main Nov 12, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-update-tsconfig-after-init-config-refresh branch November 12, 2023 22:46
zifeo pushed a commit to metatypedev/deno that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lsp doesn't respect deno.unstable (on startup)
3 participants