-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lsp doesn't respect deno.unstable (on startup) #21167
Comments
nayeemrmn
added
bug
Something isn't working correctly
lsp
related to the language server
labels
Nov 11, 2023
I spent some time today with both the LSP server and the VSCode extension looking at this issue. Here is what seems to be happening:
|
Opps, sorry @nayeemrmn I missed that you had a PR here when I commented. Yes, that looks right. I pulled it down and it fixes the issue. I'm not sure I understand the changes to the tests and how they relate to this issue, but I'll leave a comment on the PR about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While investigating (#21159) is seems there is another case where the LSP doesn't respect the unstable flag. This is unrelated to the
/// <reference no-default-lib="true" />
directive.Steps to reproduce:
Deno.dlopen
and save itdlopen
is an unstable API.If you restart the LSP, the setting sticks. Seems like a timing issue on startup.
I've attached a screengrab.
The text was updated successfully, but these errors were encountered: