Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/http2): fixes to support grpc #20712

Merged
merged 19 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert unrelated change
  • Loading branch information
bartlomieju committed Oct 6, 2023
commit f3af6430ac07d3d9d7230ac74db04bf57b95bfe9
8 changes: 2 additions & 6 deletions ext/node/polyfills/internal_binding/tcp_wrap.ts
bartlomieju marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -380,20 +380,16 @@ export class TCP extends ConnectionWrap {
this[kStreamBaseField] = conn;

try {
console.log("here");
this.afterConnect(req, 0);
} catch (e) {
console.log("here2", e);
} catch {
// swallow callback errors.
}
},
() => {
try {
console.log("here3");
// TODO(cmorten): correct mapping of connection error to status code.
this.afterConnect(req, codeMap.get("ECONNREFUSED")!);
} catch (e) {
console.log("here4", e);
} catch {
// swallow callback errors.
}
},
Expand Down
4 changes: 1 addition & 3 deletions ext/web/02_timers.js
bartlomieju marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ function setTimeout(callback, timeout = 0, ...args) {
callback = webidl.converters.DOMString(callback);
}
timeout = webidl.converters.long(timeout);
console.log(">>>> setTimeout");

return initializeTimer(callback, timeout, args, false);
}

Expand Down Expand Up @@ -371,7 +371,6 @@ function clearInterval(id = 0) {
}

function refTimer(id) {
console.log(">>>> refTimer");
const timerInfo = MapPrototypeGet(activeTimers, id);
if (timerInfo === undefined || timerInfo.isRef) {
return;
Expand All @@ -381,7 +380,6 @@ function refTimer(id) {
}

function unrefTimer(id) {
console.log(">>>> unrefTimer");
const timerInfo = MapPrototypeGet(activeTimers, id);
if (timerInfo === undefined || !timerInfo.isRef) {
return;
Expand Down