fix(node/http2): fixes to support grpc #20712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Oct 1, 2023
| @@ -264,7 +271,7 @@ export class Http2Session extends EventEmitter { | |||
| } | |||
|
|
|||
| setTimeout(msecs: number, callback?: () => void) { | |||
| setStreamTimeout(this, msecs, callback); | |||
| setStreamTimeout.call(this, msecs, callback); | |||
There was a problem hiding this comment.
This fixes problems with setStreamTimeout that were happening before
| @@ -340,6 +352,7 @@ function assertValidPseudoHeader(header: string) { | |||
|
|
|||
| export class ClientHttp2Session extends Http2Session { | |||
| #connectPromise: Promise<void>; | |||
| #refed = true; | |||
There was a problem hiding this comment.
This bit should address #16647
Comment on lines
+398
to
+410
| ref() { | ||
| this.#refed = true; | ||
| if (this[kPollConnPromiseId]) { | ||
| core.refOp(this[kPollConnPromiseId]); | ||
| } | ||
| } | ||
|
|
||
| unref() { | ||
| this.#refed = false; | ||
| if (this[kPollConnPromiseId]) { | ||
| core.unrefOp(this[kPollConnPromiseId]); | ||
| } | ||
| } |
bartlomieju
commented
Oct 1, 2023
bartlomieju
added a commit
that referenced
this pull request
Oct 12, 2023
This commit improves "node:http2" module implementation, by enabling to use "options.createConnection" callback when starting an HTTP2 session. This change enables to pass basic client-side test with "grpc-js/grpc" package. Smaller fixes like "Http2Session.unref()" and "Http2Session.setTimeout()" were handled as well. Fixes #16647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves "node:http2" module implementation, by enabling
to use "options.createConnection" callback when starting an HTTP2 session.
This change enables to pass basic client-side test with "grpc-js/grpc" package.
Smaller fixes like "Http2Session.unref()" and "Http2Session.setTimeout()"
were handled as well.
Fixes #16647