Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable permissions prompt tests #1957

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Re-enable permissions prompt tests #1957

merged 1 commit into from
Mar 18, 2019

Conversation

afinch7
Copy link
Contributor

@afinch7 afinch7 commented Mar 18, 2019 •
edited
Loading

part of #1955

ry
ry approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - LGTM! I should have checked after merging #1926

@ry ry merged commit e98d339 into denoland:master Mar 18, 2019
@ry ry mentioned this pull request Mar 18, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afinch7 @ry