Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable REPL tests #1955

Closed
4 of 7 tasks
ry opened this issue Mar 18, 2019 · 2 comments
Closed
4 of 7 tasks

re-enable REPL tests #1955

ry opened this issue Mar 18, 2019 · 2 comments
Labels
repl related to the Read-Eval-Print-Loop functionality of Deno

Comments

@ry
Copy link
Member

ry commented Mar 18, 2019 •
edited
Loading

"core" is a major API refactor that significantly simplified and sped up the code base. However not all issues have been worked out - it was landed with some tests disabled.
See b672c12

These are tests that need to be turned back on:

  • tests/error_004_missing_module.test
  • tests/error_005_missing_dynamic_import.test
  • tests/error_006_import_ext_failure.test
  • repl_test test_set_timeout
  • repl_test test_async_op
  • repl_test test_set_timeout_interlaced
  • all of permission_prompt_test Re-enable permissions prompt tests #1957
@afinch7 afinch7 mentioned this issue Mar 18, 2019
Merged
@afinch7 afinch7 mentioned this issue Mar 28, 2019
Merged
@bartlomieju
Copy link
Member

FYI tests/error_* are enabled and passing, only repl_test are disabled.

@bartlomieju bartlomieju changed the title re-enable tests that were disabled during core integration re-enable REPL tests Dec 28, 2019
@bartlomieju bartlomieju added the repl related to the Read-Eval-Print-Loop functionality of Deno label Feb 24, 2020
@bartlomieju
Copy link
Member

REPL tests were rewritten to Rust, this issue is no longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repl related to the Read-Eval-Print-Loop functionality of Deno
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ry @bartlomieju