Revert "fix(cli): deno upgrade file permission (#18427)" #18467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0742ea1.
dsherret
reviewed
Mar 27, 2023
| @@ -265,15 +265,13 @@ pub async fn upgrade( | |||
| ) -> Result<(), AnyError> { | |||
| let ps = ProcState::build(flags).await?; | |||
| let current_exe_path = std::env::current_exe()?; | |||
| let output_exe_path = | |||
| upgrade_flags.output.as_ref().unwrap_or(¤t_exe_path); | |||
| let metadata = fs::metadata(output_exe_path)?; | |||
There was a problem hiding this comment.
Can we just change this to never throw?
There was a problem hiding this comment.
Agreed. The fix is easier than the revert.
There was a problem hiding this comment.
I'm not sure I understand how to change that... metadata and permissions by extension are used further down in the file. How should that be changed?
There was a problem hiding this comment.
At least a quick scroll down says that metadata is only used to check for permissions and root ownership. All of that is unnecessary if the file doesn't exist yet and thus could be handled in a if let Some() branch I think.
dsherret
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0742ea1.
Closes #18466
CC @rottenpen