Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): deno upgrade file permission #18427

Merged
merged 3 commits into from
Mar 26, 2023
Merged

fix(cli): deno upgrade file permission #18427

merged 3 commits into from
Mar 26, 2023

Conversation

rottenpen
Copy link
Contributor

fix: #18411

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aapoalas
aapoalas approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, this is a very nice fix indeed! I pushed a change (two, because I bollixed it the first time around) to fix lint but otherwise this looks good to me.

@sepehrst
Copy link

The title of the PR is somewhat misleading. despite the fix(cli) prefix, deno upgrade permission implies that this is an upgrade to the Deno permission system rather than a fix for file permission handling in the upgrade subcommand.
So maybe fix(cli): file permission handling in deno-upgrade or something like that?

@aapoalas aapoalas changed the title fix(cli): deno upgrade permission fix(cli): deno upgrade file permission Mar 26, 2023
@aapoalas aapoalas merged commit 0742ea1 into denoland:main Mar 26, 2023
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Mar 27, 2023
@bartlomieju
Revert "fix(cli): deno upgrade file permission (denoland#18427)"
3863db2 
This reverts commit 0742ea1.
dsherret pushed a commit that referenced this pull request Mar 31, 2023
@bartlomieju
Revert "fix(cli): deno upgrade file permission (#18427)" (#18467)
cbd1408 
This reverts commit 0742ea1.

Closes #18466
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@rottenpen @mmastrac
fix(cli): deno upgrade file permission (#18427)
7fa2bf3
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@bartlomieju @mmastrac
Revert "fix(cli): deno upgrade file permission (#18427)" (#18467)
7583cb4 
This reverts commit 0742ea1.

Closes #18466
@GJZwiers GJZwiers mentioned this pull request Apr 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno upgrade permission check should check cliOptionOutput
4 participants
@rottenpen @CLAassistant @sepehrst @aapoalas