Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tools): restore node compat test setup script #18290

Merged
merged 6 commits into from
Mar 21, 2023
Merged

chore(tools): restore node compat test setup script #18290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43d0eda
chore(tools): add node compat setup script
kt3k Mar 20, 2023
135001d
chore: remove failing node compat tests
kt3k Mar 20, 2023
c0fdfde
chore: use single export
kt3k Mar 20, 2023
17d9eb2
modify
kt3k Mar 20, 2023
a53e92f
restore common/hijackstdio.js
kt3k Mar 20, 2023
fa055be
fix lint error
kt3k Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .dprint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"test_util/std",
"test_util/wpt",
"third_party",
"tools/node_compat/TODO.md",
"tools/node_compat/versions",
"tools/wpt/expectation.json",
"tools/wpt/manifest.json"
],
Expand Down
6 changes: 3 additions & 3 deletions cli/tests/node_compat/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
import { partition } from "std/collections/mod.ts";
import { join } from "std/path/mod.ts";
import { partition } from "../../../test_util/std/collections/partition.ts";
import { join } from "../../../test_util/std/path/mod.ts";

/**
* The test suite matches the folders inside the `test` folder inside the
Expand Down Expand Up @@ -35,7 +35,7 @@ export const ignoreList = Object.entries(config.ignore).reduce(
paths.forEach((path) => total.push(new RegExp(join(suite, path))));
return total;
},
[],
[/package\.json/],
);

export function getPathsFromTestSuites(suites: TestSuites): string[] {
Expand Down
Loading