Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): use static specifier in ExtensionFileSource #18264

Merged
merged 5 commits into from
Mar 18, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Mar 18, 2023

Closes #18085

@bartlomieju
Copy link
Member

Seems like this could close #18085 - can you also change ModuleMap::serialize_for_snapshotting and ModuleMap::update_with_snapshotted_data to use one-byte external strings for these specifiers?

@bartlomieju bartlomieju enabled auto-merge (squash) March 18, 2023 12:52
@bartlomieju bartlomieju merged commit 8af0c83 into denoland:main Mar 18, 2023
@bartlomieju bartlomieju deleted the static_str_esmsource branch March 18, 2023 14:36
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Mar 18, 2023
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Mar 18, 2023
bartlomieju added a commit that referenced this pull request Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshotted modules from Extensions should require one-byte names and specifiers
2 participants