Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshotted modules from Extensions should require one-byte names and specifiers #18085

Closed
bartlomieju opened this issue Mar 9, 2023 · 0 comments · Fixed by #18264
Closed

Snapshotted modules from Extensions should require one-byte names and specifiers #18085

bartlomieju opened this issue Mar 9, 2023 · 0 comments · Fixed by #18264
Assignees
@bartlomieju
Labels
deno_core Changes in "deno_core" crate are needed perf performance related

Comments

@bartlomieju
Copy link
Member

Currently we're spending around 1.5% of startup time on deserializing snapshotted modules. Most of that time is spent v8::String and Rust's string deserialization. We should enforce using one-byte strings for Extension's name and specifier to reduce this cost.
@bartlomieju bartlomieju added the deno_core Changes in "deno_core" crate are needed label Mar 9, 2023
@bartlomieju bartlomieju self-assigned this Mar 9, 2023
@bartlomieju bartlomieju added the perf performance related label Mar 9, 2023
@bartlomieju bartlomieju mentioned this issue Mar 18, 2023
Merged
bartlomieju added a commit that referenced this issue Mar 18, 2023
@littledivy @bartlomieju
perf(core): use static specifier in ExtensionFileSource (#18264)
8af0c83 
Closes #18085

---------

Co-authored-by: Bartek Iwańczuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
deno_core Changes in "deno_core" crate are needed perf performance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(core): use static specifier in ExtensionFileSource littledivy/deno
1 participant
@bartlomieju