Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(streams): add support Float64Array to ReadableStreamByobReader #18188

Merged
merged 7 commits into from
Mar 27, 2023
Merged

fix(streams): add support Float64Array to ReadableStreamByobReader #18188

merged 7 commits into from
Mar 27, 2023

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Mar 14, 2023 •
edited
Loading

Closes #13176
This PR is an alternative of #17327. However, there is no update WPT test yet.

aapoalas
aapoalas approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Lack of a test would normally be a blocker for merging but I'll let the core team decide on this case since it's a matter of WPT test missing and not something Deno would normally implement directly.

crowlKats
crowlKats reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative PR is blocked on WPT which i will work on soon, so this PR is blocked on WPT as well.

@crowlKats crowlKats mentioned this pull request Mar 18, 2023
Closed
@petamoriken petamoriken mentioned this pull request Mar 19, 2023
Merged
@bartlomieju
Copy link
Member

Since this passes all WPT it appears to be non-breaking. Maybe we can land it without a test before #17327?

crowlKats
crowlKats approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 2b389ec into denoland:main Mar 27, 2023
@petamoriken petamoriken deleted the fix/readable-stream-float64array branch March 27, 2023 15:14
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@petamoriken @mmastrac
fix(streams): add support Float64Array to ReadableStreamByobReader (
5ef4cef 
#18188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadableStreamBYOBReader.read<Float64Array>(view: Float64Array) returns DataView
4 participants
@petamoriken @bartlomieju @crowlKats @aapoalas