Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streams): add Float64Array to ReadableStreamByobReader.read #17327

Closed
wants to merge 2 commits into from

Conversation

crowlKats
Copy link
Member

Closes #13176
will look into adding WPT separately later on.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do WPT in this PR?

@petamoriken
Copy link
Contributor

It would be better to use TypedArrayPrototypeGetSymbolToStringTag
#17431 (review)

@aapoalas
Copy link
Collaborator

Linked issue is now merged, this can probably proceed.

@crowlKats
Copy link
Member Author

Linked issue is now merged, this can probably proceed.

still need to write a WPT

@bartlomieju
Copy link
Member

@crowlKats could you finish this PR?

@crowlKats
Copy link
Member Author

Closing in favour of #18188

@crowlKats crowlKats closed this Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadableStreamBYOBReader.read<Float64Array>(view: Float64Array) returns DataView
4 participants