Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): More efficient serde for ES modules in snapshot #17856

Merged
merged 7 commits into from
Feb 21, 2023
Merged

refactor(core): More efficient serde for ES modules in snapshot #17856

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
11e891c
more efficient deserialization
bartlomieju Feb 21, 2023
7f73dd2
don't store urls in snapshot data
bartlomieju Feb 21, 2023
68b71b9
more efficient serde for ModuleInfo
bartlomieju Feb 21, 2023
bef9a95
more efficient serde for ModuleMap::by_name
bartlomieju Feb 21, 2023
653b2c3
cleanup
bartlomieju Feb 21, 2023
b72d2c5
Merge branch 'main' into faster_startup_core
bartlomieju Feb 21, 2023
2623700
review
bartlomieju Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@bartlomieju
bartlomieju committed Feb 21, 2023
commit 653b2c3d2cc2919139a23d2764543bdf01426082
5 changes: 3 additions & 2 deletions core/modules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,12 +1051,13 @@ impl ModuleMap {
for (i, elem) in self.by_name.iter().enumerate() {
let arr = v8::Array::new(scope, 3);

let specifier = v8::String::new(scope, &elem.0 .0).unwrap();
let (specifier, asserted_module_type) = &elem.0;
let specifier = v8::String::new(scope, specifier).unwrap();
arr.set_index(scope, 0, specifier.into());

let asserted_module_type = v8::Integer::new(
scope,
match elem.0 .1 {
match asserted_module_type {
AssertedModuleType::JavaScriptOrWasm => 0,
AssertedModuleType::Json => 1,
},
Expand Down