refactor(core): More efficient serde for ES modules in snapshot #17856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on "serde_v8" which is very inefficient in serializing enums, I'm
hand rolling serde for "ModuleMap" data that is stored in the V8 snapshot to make
ES modules snapshottable.
Will post number comparison later, but I don't expect more than 5-10% improvement in
startup time.
EDIT: Benchmark results: