Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): only run doc tests on linux #17379

Merged
merged 4 commits into from
Jan 13, 2023
Merged

chore(ci): only run doc tests on linux #17379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f6f920
chore(ci): only run doc tests on linux
dsherret Jan 12, 2023
665c2a6
Try this [ci]
dsherret Jan 12, 2023
4c41f6f
Fix. test not tests
dsherret Jan 12, 2023
8688a69
Merge branch 'main' into chore_doc_tests_linux
dsherret Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(ci): only run doc tests on linux
  • Loading branch information
@dsherret
dsherret committed Jan 12, 2023
commit 0f6f9202f31988a15a5d84b4bb56b5b6c07d8cb7
14 changes: 11 additions & 3 deletions .github/workflows/ci.generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,15 +586,23 @@ const ci = {
run:
'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs:https://dl.deno.land/canary/$(git rev-parse HEAD)/',
},
{
name: "Test debug (doc)",
dsherret marked this conversation as resolved.
Show resolved Hide resolved
if: [
// only bother running on linux CI
"startsWith(matrix.os, 'ubuntu') &&",
"matrix.job == 'test' && matrix.profile == 'debug' &&",
"!startsWith(github.ref, 'refs/tags/')",
].join("\n"),
run: "cargo test --locked --doc",
},
{
name: "Test debug",
if: [
"matrix.job == 'test' && matrix.profile == 'debug' &&",
"!startsWith(github.ref, 'refs/tags/')",
].join("\n"),
run: ["cargo test --locked --doc", "cargo test --locked"].join(
"\n",
),
run: "cargo test --locked",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already does --doc. We were testing doc twice here.

},
{
name: "Test fastci",
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,13 +366,17 @@ jobs:
CLOUDSDK_PYTHON: '${{env.pythonLocation}}\python.exe'
shell: bash
run: 'gsutil -h "Cache-Control: public, max-age=3600" cp ./target/release/*.zip gs:https://dl.deno.land/canary/$(git rev-parse HEAD)/'
- name: Test debug (doc)
if: |-
!(github.event_name == 'pull_request' && matrix.skip_pr) && (steps.exit_early.outputs.EXIT_EARLY != 'true' && (startsWith(matrix.os, 'ubuntu') &&
matrix.job == 'test' && matrix.profile == 'debug' &&
!startsWith(github.ref, 'refs/tags/')))
run: cargo test --locked --doc
- name: Test debug
if: |-
!(github.event_name == 'pull_request' && matrix.skip_pr) && (steps.exit_early.outputs.EXIT_EARLY != 'true' && (matrix.job == 'test' && matrix.profile == 'debug' &&
!startsWith(github.ref, 'refs/tags/')))
run: |-
cargo test --locked --doc
cargo test --locked
run: cargo test --locked
- name: Test fastci
if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (steps.exit_early.outputs.EXIT_EARLY != ''true'' && ((matrix.job == ''test'' && matrix.profile == ''fastci'')))'
run: cargo test --locked
Expand Down