Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): only run doc tests on linux #17379

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

dsherret
Copy link
Member

Doc tests were observed to take over 100s on the Mac CI in one instance. We might as well only run this on the Linux CI because our docs seem to be cross platform. Any cross platform issues can be caught locally by developers contributing to the project.

2023-01-12T22:02:30.6140250Z [0m[0m[1m[32m   Doc-tests[0m deno_core
2023-01-12T22:02:32.6324310Z 
2023-01-12T22:02:32.6346910Z running 4 tests
2023-01-12T22:02:32.6347950Z test bindings.rs - bindings::call_console (line 523) ... ignored
2023-01-12T22:02:32.6354860Z test extensions.rs - extensions::include_js_files (line 215) ... ignored
2023-01-12T22:03:32.7603850Z test async_cell.rs - async_cell::RcRef (line 125) has been running for over 60 seconds
2023-01-12T22:03:32.7604710Z test resources.rs - resources::ResourceTable::names (line 342) has been running for over 60 seconds
2023-01-12T22:04:26.6187450Z test async_cell.rs - async_cell::RcRef (line 125) ... ok
2023-01-12T22:04:27.0016040Z test resources.rs - resources::ResourceTable::names (line 342) ... ok
2023-01-12T22:04:27.0016310Z 
2023-01-12T22:04:27.0016520Z test result: ok. 2 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 114.37s

@dsherret dsherret marked this pull request as draft January 12, 2023 23:44
run: ["cargo test --locked --doc", "cargo test --locked"].join(
"\n",
),
run: "cargo test --locked",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already does --doc. We were testing doc twice here.

@dsherret dsherret marked this pull request as ready for review January 12, 2023 23:57
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 5a84ecf into denoland:main Jan 13, 2023
@dsherret dsherret deleted the chore_doc_tests_linux branch January 13, 2023 00:56
dsherret added a commit that referenced this pull request Jan 13, 2023
Doc tests were observed to take over 100s on the Mac CI in one instance.
dsherret added a commit that referenced this pull request Jan 13, 2023
Doc tests were observed to take over 100s on the Mac CI in one instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants