Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): only install node for the benchmarks #17371

Merged
merged 3 commits into from
Jan 12, 2023
Merged

chore(ci): only install node for the benchmarks #17371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05c83d9
chore(ci): only install node for the benchmarks
dsherret Jan 12, 2023
ae54c1d
Merge branch 'main' into chore_install_node_benches
dsherret Jan 12, 2023
3f7bf08
Fix merge issue
dsherret Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into chore_install_node_benches
  • Loading branch information
@dsherret
dsherret committed Jan 12, 2023
commit ae54c1d8c07d120d110a8d86d844a2592994c0fb
1 change: 1 addition & 0 deletions .github/workflows/ci.generate.ts
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ const ci = {
...installDenoStep,
},
...installPythonSteps,
authenticateWithGoogleCloud,
{
// only necessary for benchmarks
if: "matrix.job == 'bench'",
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,19 @@ jobs:
Where-Object { Test-Path "$_\python.exe" } |
Select-Object -Skip 1 |
ForEach-Object { Move-Item "$_" "$_.disabled" }
- name: Authenticate with Google Cloud
if: |-
!(github.event_name == 'pull_request' && matrix.skip_pr) && (steps.exit_early.outputs.EXIT_EARLY != 'true' && (matrix.profile == 'release' &&
matrix.job == 'test' &&
github.repository == 'denoland/deno' &&
(github.ref == 'refs/heads/main' ||
startsWith(github.ref, 'refs/tags/'))))
uses: google-github-actions/auth@v1
with:
project_id: denoland
credentials_json: '${{ secrets.GCP_SA_KEY }}'
export_environment_variables: true
create_credentials_file: true
- if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (steps.exit_early.outputs.EXIT_EARLY != ''true'' && (matrix.job == ''bench''))'
name: Install Node
uses: actions/setup-node@v3
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.