Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): only install node for the benchmarks #17371

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

dsherret
Copy link
Member

The mtime_cache also uses this, but there's a using: node16 defined in mtime_cache/action.yml

Installing Node can sometimes be slow and it seems to only be necessary for the benchmarks.

image

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit dabcdf2 into denoland:main Jan 12, 2023
@dsherret dsherret deleted the chore_install_node_benches branch January 12, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants