Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(napi): functions related to errors #17370

Merged
merged 19 commits into from
Jan 15, 2023
Merged

fix(napi): functions related to errors #17370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8357cc2
wip, some tests working
bartlomieju Jan 12, 2023
c66e8d9
wip
bartlomieju Jan 12, 2023
aab8165
finish tests
bartlomieju Jan 12, 2023
03e5dc4
add cstr! macro
bartlomieju Jan 12, 2023
3e0ac45
more apis
bartlomieju Jan 12, 2023
13a2d3a
napi_clear_last_error
bartlomieju Jan 12, 2023
cfcd1c4
add check env
bartlomieju Jan 13, 2023
46b85a1
add napi_to_v8
bartlomieju Jan 13, 2023
8c660eb
check_new_from_utf8
bartlomieju Jan 13, 2023
4fdb06f
use cstr!
bartlomieju Jan 13, 2023
4c989c5
use more return_status_if_false
bartlomieju Jan 13, 2023
b4ce5d3
use more cstr
bartlomieju Jan 13, 2023
3e96ad3
Merge branch 'main' into napi_error_tests
bartlomieju Jan 13, 2023
7892c7c
some lints
bartlomieju Jan 13, 2023
90d3dc9
use qualifier
bartlomieju Jan 13, 2023
4470e3a
Merge branch 'main' into napi_error_tests
bartlomieju Jan 14, 2023
fd20551
napi_value_unchecked
bartlomieju Jan 14, 2023
b0a1b7a
borrow mut error
bartlomieju Jan 14, 2023
5d3a065
simplify macros
bartlomieju Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/napi/env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ fn napi_get_node_version(
env: *mut Env,
result: *mut *const napi_node_version,
) -> Result {
let _: &mut Env = env.as_mut().ok_or(Error::InvalidArg)?;
crate::check_arg!(result);
crate::check_env!(env);
crate::check_arg!(env, result);

*result = &NODE_VERSION as *const napi_node_version;
Ok(())
Expand Down
Loading