fix(napi): functions related to errors #17370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
force-pushed
the
napi_error_tests
branch
from
fb6388e
to
13a2d3a
Compare
littledivy
reviewed
Jan 14, 2023
Comment on lines
+262
to
+263
| check_env!(env); | ||
| let env = unsafe { &mut *env }; |
There was a problem hiding this comment.
Why this instead of just let env: &mut Env = env.as_mut().ok_or(Error::InvalidArg)?;
There was a problem hiding this comment.
Because .as_mut() consumes the pointer and makes it impossible to create a value out of scope, assign it to the result pointer and later call a function like napi_clear_error_code
bartlomieju
changed the title
bartlomieju
added a commit
that referenced
this pull request
Jan 16, 2023
This commits fixes various NAPI functions related to creation and throwing of errors.
MierenManz
added a commit
to MierenManz/oned
that referenced
this pull request
Jan 20, 2023
This reverts commit df8bfa2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits fixes various NAPI functions related to creation and throwing
of errors.