fix: retry module download once if server errored #17252
Conversation
@piscisaureus this link is not working for me, could you point to relevant line in code? |
cli/file_fetcher.rs
Outdated
| FetchOnceResult::ServerError(status) => { | ||
| // Retry once, and bail otherwise. | ||
| if !retried { | ||
| retried = true; |
There was a problem hiding this comment.
Should we do a slight delay when retrying? (maybe a few ms)
| let mut res = Response::new(Body::empty()); | ||
| *res.status_mut() = StatusCode::INTERNAL_SERVER_ERROR; | ||
| Ok(res) | ||
| } |
There was a problem hiding this comment.
Should we add an endoint that errors the first time and succeeds the second?
There was a problem hiding this comment.
It's gonna be hard to add state to that server to verify how many times this function was called...
cli/file_fetcher.rs
Outdated
| // Retry once, and bail otherwise. | ||
| if !retried { | ||
| retried = true; | ||
| continue; |
There was a problem hiding this comment.
Perhaps we should log::warn when this occurs?
There was a problem hiding this comment.
Now that I'm thinking about it - a flake will cause this to be printed which will still fail tests. Maybe it should be log::debug instead?
Closes #17251
Closes #19970