Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry downloading module on failure #17251

Closed
piscisaureus opened this issue Jan 3, 2023 · 1 comment · Fixed by #17252
Closed

Retry downloading module on failure #17251

piscisaureus opened this issue Jan 3, 2023 · 1 comment · Fixed by #17252

Comments

@piscisaureus
Copy link
Member

When a transient error (e.g. 5xx status code or connection reset error) is encountered while downloading a module, give it another shot.

This avoids annoyances like below, and I can't think of any downsides.

image
@bartlomieju bartlomieju mentioned this issue Jan 3, 2023
Merged
bartlomieju added a commit that referenced this issue Aug 1, 2023
@bartlomieju
fix: retry module download once if server errored (#17252)
5df2b0b 
Closes #17251
Closes #19970

This commits adds logic to retry failed module downloads once.
Both request and server errors are handled and the retry is done after
50 ms wait time.
@bombillazo
Copy link

bombillazo commented Oct 3, 2023 •
edited
Loading

Was this solved? we are getting this frequently during our GH actions deno compile...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: retry module download once if server errored bartlomieju/deno
2 participants
@piscisaureus @bombillazo