Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): handle URL in createRequire #16682

Merged
merged 2 commits into from
Nov 19, 2022
Merged

fix(ext/node): handle URL in createRequire #16682

merged 2 commits into from
Nov 19, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 17, 2022

This PR implements handling of URL input for createRequire in ext/node.

part of #16659

bartlomieju
bartlomieju approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsherret
dsherret reviewed Nov 17, 2022
View reviewed changes
ext/node/02_require.js Outdated Show resolved Hide resolved
@kt3k kt3k merged commit 7ab0813 into denoland:main Nov 19, 2022
@kt3k kt3k deleted the npm-handle-url-obj branch November 19, 2022 11:32
bartlomieju pushed a commit that referenced this pull request Nov 24, 2022
@kt3k @bartlomieju
fix(ext/node): handle URL in createRequire (#16682)
a20fd23
@zuisong zuisong mentioned this pull request Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kt3k @dsherret @bartlomieju