Support Astro

[kt3k]

Tracking issue for supporting astro.

Known issues:

• TypeError: Cannot set property localStorage of #<Window> which has only a getter when running deno run npm:astro dev
• ReferenceError: process is not defined at validateComponentProps (/node_modules/.deno/[email protected]/node_modules/astro/dist/runtime/server/render/astro.js, <anonymous>:13:61) This error (strangely) disappeared on the latest version.
• createRequire doesn't accept URL (issue for [email protected], but not for latest)
• astro dev hangs without any error message flash: Deno.serve drops response body chunks if empty chunk is enqueued #17194 fix(node/http): avoid empty chunk issue of flash std#3062
• astro build requires the import map of {"html-escaper": "npm:html-escaper"} to work correctly.

[brenelz]

Now it gets by that error and I get the following:

Expected string at position 0
TypeError: Expected string at position 0
at createRequire (deno:ext/node/02_require.js:823:31)
at new DependencyWalker (file:https:///Users/brenelz/Desktop/denoland/deno/node_modules/.deno/[email protected]/node_modules/astro/dist/core/create-vite.js:129:20)

[kt3k]

TypeError: Expected string at position 0

Added it to the issue list. (createRequire doesn't accept URL)

[kt3k]

The 2nd issue disappeared. Added the 4th and 5th issues.

[brenelz]

So I played around with it and it seems to be some kind of bug with ReadableStream. If i turn off streaming it works fine.

https://github.com/withastro/astro/blob/main/packages/astro/src/core/render/dev/environment.ts#L35

[brenelz]

So I think the issue is it sending a 0 length UIntArray which is screwing up ReadableStream

[kt3k]

@brenelz I looked into your fix in details, and it looked like 0 length Uint8Array is ok for ReadableStream, but it causes an issue in our server implementation (Deno.serve) #17194. I created an workaround in deno_std denoland/std#3062. Thanks for your research!

[brenelz]

@kt3k should I close my pr then? Hopefully it at least helped put you on the right track. I would test it but not sure how to use in progress deno_std

[kt3k]

@brenelz

I would test it but not sure how to use in progress deno_std

You can replace std/node implementation with your local one, by setting DENO_NODE_COMPAT_URL env var, like:

DENO_NODE_COMPAT_URL=file:https:///path/to/deno_std/ deno run -A --node-modules-dir npm:astro dev

You can also replace it with one in a remote branch, like:

DENO_NODE_COMPAT_URL=https://raw.githubusercontent.com/kt3k/deno_std/workaround-empty-chunk-issue/ deno run -A --node-modules-dir npm:astro dev

[brenelz]

Works great from what I can tell. Thanks!

[kt3k]

Now astro dev command seems working.

(The below steps work with 1.31.0)

deno run -A npm:create-astro my-app
cd my-app
deno task dev

astro build still fails with the error Relative import path "html-escaper" not prefixed with / or ./ or ../

[lilnasy]

There seems to have been a regression since 1.31, there are multiple other dependencies that fail to resolve now.

[lilnasy]

Deno can run dev for an older version of Astro

Newer versions fail in a variety of ways

[bartlomieju]

@lilnasy the problem you with the latest Deno version should be fixed by #18948 and will be released in Deno 1.32.2 later this week.

[lilnasy]

@bartlomieju I built and ran deno from your branch, and I can cofirm those issues are gone, but there are others blocking astro support still. In particular, detecting package.json breaks module graph resolution.

[bartlomieju]

Thanks for the report. I will take a deeper look at Astro in the coming days.

[lilnasy]

There was more progress in 1.33.4. Now seems to be blocked on createBrotliDecompress.

[lilnasy]

Thanks to @bartlomieju, astro is really close to working on deno again. The one blocker is undici, which isn't even necessary on deno, and planned for removal with node 16 EOL.

[bartlomieju]

@lilnasy thanks for keeping tabs. We did not manage to complete createBrotliDecompress for v1.33.4 but we'll try to ship it for v1.34 next week. If you find any more quirks, make sure to let me know!

[bartlomieju]

With #19223 landed Astro should now work in Deno. I'm gonna close this issue, please open new issues if you hit any more problems.