feat(ext/ffi): Add static method variants to Deno.UnsafePointerView #15146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add static method variants to Deno.UnsafePointerView for usage with pointer BigInts. Since
Deno.UnsafePointer
is no longer a thing that exists andBigInt
values are returned directly, it seems like it might be helpful to offer static variants for the more direct return types that Deno FFI does not directly support.This PR depends on #15143
Examples:
These static methods do not have pointer offsets offered, as those seem like a special case and if offsets are needed, then creating a
Deno.UnsafePointerView
seems apt to actually "view into" the pointer.Additionally, I did not create static methods for the numeric return values as it seems unlikely that a function would return just a
*const u8
or similar. Again, if viewing into a pointer that contains a struct which contains numeric values is needed, then creating aDeno.UnsafePointerView
seems apt.