feat(ext/ffi): Add support to get ArrayBuffers from UnsafePointerView #15143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
force-pushed
the
feat-ext-ffi-pointer-to-array-buffer
branch
from
68a340a
to
4d06d71
Compare
Officialstrike
pushed a commit
to Officialstrike/deno
that referenced
this pull request
Jul 30, 2022
crowlKats
pushed a commit
that referenced
this pull request
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes for
UnsafePointerView'sgetArrayBuffermethod to actually return an ArrayBuffer backed by the actual pointer's source data. This means that mutable data can be mutated directly from JS without any library APIs or specific FFI APIs.This is absolutely unsafe and can easily lead to segfaults. Users need to be massively careful with this. At the same time, this is also something that is eg. needed by ObjectC C API.