Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/fetch): remove deprecation of URL in deno fetch #14769

Merged
merged 3 commits into from
Jun 6, 2022
Merged

fix(ext/fetch): remove deprecation of URL in deno fetch #14769

merged 3 commits into from
Jun 6, 2022

Conversation

mrkldshv
Copy link
Contributor

@mrkldshv mrkldshv commented Jun 1, 2022

Remove deprecation of URL as the first argument in deno fetch.

Closes #14620.

kt3k
kt3k approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib.dom's fetch declaration is updated in #14242 (TypeScript 4.7 update), which includes URL in the 1st arg. We should align this again

bartlomieju
bartlomieju approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bartlomieju bartlomieju merged commit cfb6067 into denoland:main Jun 6, 2022
@mrkldshv mrkldshv deleted the bugfix/undeprecate-fetch-url branch June 7, 2022 00:14
cjihrig pushed a commit that referenced this pull request Jun 9, 2022
@mrkldshv @cjihrig
fix(ext/fetch): remove deprecation of URL in deno fetch (#14769)
f354d41
@ayame113 ayame113 mentioned this pull request Jul 16, 2022
Merged
@kt3k kt3k mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undeprecate the URL parameter of fetch
3 participants
@mrkldshv @kt3k @bartlomieju