feat: update to TypeScript 4.7 #14242
Conversation
| @@ -7,10 +7,6 @@ | |||
|
|
|||
| /// <reference no-default-lib="true"/> | |||
|
|
|||
| interface AbortSignal extends EventTarget { | |||
There was a problem hiding this comment.
This is now part of lib dom.
| // code_actions: Option<Vec<CodeAction>>, | ||
| // source: Option<Vec<SymbolDisplayPart>>, |
There was a problem hiding this comment.
this is deprecated, so we shouldn't ever use it if we need it.
kitsonk
changed the title
kitsonk
requested review from
bartlomieju,
crowlKats,
lucacasonato and
dsherret
as code owners
| @@ -695,7 +723,7 @@ interface AbortController { | |||
| /** Returns the AbortSignal object associated with this object. */ | |||
| readonly signal: AbortSignal; | |||
| /** Invoking this method will set this object's AbortSignal's aborted flag and signal to any observers that the associated activity is to be aborted. */ | |||
| abort(reason?: any): void; | |||
| // abort(): AbortSignal; - To be re-added in the future | |||
There was a problem hiding this comment.
Is this on purpose? Looks strange
There was a problem hiding this comment.
Agreed, this seems a bit problematic.
There was a problem hiding this comment.
It is what is upstream: https://github.com/microsoft/TypeScript/blob/release-4.7/lib/lib.webworker.d.ts#L726
I really don't want to get into updating their distributables if we can avoid it. It appears they have fixed it in main, but that is what they issued with 4.7. The impact on Deno users will be minimal, because it only gets used when users explicitly use it.
I would rather get it in so canary has it so it isn't some big surprise when it makes the release as it may highlight more "breakages" in It is mostly atomic except for the LSP changes, and even then, it is stuff we likely won't be touching anytime soon. Also, I am away the week of June 13th. |
Okay, let's land it now then. I'll cut the 1.23.2 release and deal with any troubles then. |
No description provided.