Implement console.groupCollapsed #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
force-pushed
the
feature/console-group-collapsed
branch
3 times, most recently
from
c9d132c
to
861a7e1
Compare
- add console.group & console.groupEnd function - add console.group & console.groupEnd test - fix group when log info contains \n
kt3k
force-pushed
the
feature/console-group-collapsed
branch
from
861a7e1
to
fd3a409
Compare
kt3k
changed the title
This implementation of groupCollapsed is intentionally different from the spec defined by whatwg. See the conversation in denoland#1355 and denoland#1363.
kt3k
force-pushed
the
feature/console-group-collapsed
branch
from
fd3a409
to
e798648
Compare
ry
reviewed
Jan 4, 2019
| } | ||
| if (this.collapsedAt != null && this.collapsedAt >= this.indentLevel) { | ||
| this.collapsedAt = null; | ||
| this.log(); // When the collapsed state ended, outputs a sinle new line. |
There was a problem hiding this comment.
Because this class seems using PrintFunc for any output. Do you think we should use deno.stdout/deno.stderr for any output of console's methods?
There was a problem hiding this comment.
@ry I tried to replace printFunc calls with stdout/stderr calls, but I realized that stdout.write is async function and not usable as replacement of printFunc (libdeno.print). Probably we need to have sync version of write first. How do you think?
ref: kt3k@1e9bd29
There was a problem hiding this comment.
Right - makes sense - I forgot that the writes to stdout/err are non-blocking.
ry
approved these changes
Jan 6, 2019
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1363.
This PR implements console.groupCollapsed as discussed in #1355 and #1363.
When groupCollapsed is called,
consolegoes to 'collapsed mode' and stop printing newlines on logging methods. When further group/groupCollapsed methods are called, console keeps the collapsed mode. When groupEnd which corresponds to the first groupCollapsed call is called, console gets out of 'collapsed mode'.remaining tasks (all done):
use groupCollapsed in testinglater in deno_std