Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add console.group & console.groupEnd #1363

Closed
wants to merge 3 commits into from
Closed

add console.group & console.groupEnd #1363

wants to merge 3 commits into from

Conversation

zhmushan
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhmushan zhmushan mentioned this pull request Dec 18, 2018
Closed
15 tasks
justjavac
justjavac reviewed Dec 18, 2018
View reviewed changes
js/console.ts Outdated Show resolved Hide resolved
js/console.ts Outdated Show resolved Hide resolved
@ry
Copy link
Member

ry commented Dec 18, 2018

In #1355 we are discussing using console.group() to print to the same line - like in the test runner you might want to print "testing foo bar..." and then later on the same line "ok!"
What do you think?

@hayd
Copy link
Contributor

hayd commented Dec 18, 2018

Would it be weird to special case a group label to do the single line, e.g. group("")?

I think that change is a little more complicated (requires modifying printFunc) so it could be done later...

@justjavac
Copy link
Contributor

what about groupCollapsed #1355 (comment)

@zhmushan
Copy link
Contributor Author

@justjavac I don't know how to collapse info in the terminal.
Is there a similar example?

1 similar comment
@zhmushan
Copy link
Contributor Author

@justjavac I don't know how to collapse info in the terminal.
Is there a similar example?

@ry
Copy link
Member

ry commented Dec 21, 2018

Waiting for #1355 to land.

@kt3k Do you have some opinion on if we should use console.group or console. groupCollapsed printing to the same line?

@kt3k
Copy link
Member

kt3k commented Dec 23, 2018

@ry
I think console.groupCollapsed would be better for printing to the same line because it seems 'collapsed' and it doesn't have any use case in terminal (because there is no acutual 'collapse' behavior there).

@axetroy axetroy mentioned this pull request Dec 25, 2018
Closed
kt3k added a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@kt3k
feat: implement console.groupCollapsed
86b8617 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in denoland#1355
and denoland#1363.
kt3k added a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@kt3k
feat: implement console.groupCollapsed
b4ff84a 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in denoland#1355
and denoland#1363.
@kt3k kt3k mentioned this pull request Jan 3, 2019
Merged
2 tasks
kt3k added a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@kt3k
feat: implement console.groupCollapsed
d9502e3 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in denoland#1355
and denoland#1363.
kt3k added a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@kt3k
feat: implement console.groupCollapsed
c9d132c 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in denoland#1355
and denoland#1363.
kt3k added a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@kt3k
feat: implement console.groupCollapsed
861a7e1 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in denoland#1355
and denoland#1363.
kt3k pushed a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@zhmushan @kt3k
add console.group & console.groupEnd denoland#1363
02b6950 
- add console.group & console.groupEnd function
- add console.group & console.groupEnd test
- fix group when log info contains \n
kt3k added a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@kt3k
feat: implement console.groupCollapsed
fd3a409 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in denoland#1355
and denoland#1363.
kt3k added a commit to kt3k/deno that referenced this pull request Jan 3, 2019
@kt3k
feat: implement console.groupCollapsed
e798648 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in denoland#1355
and denoland#1363.
ry pushed a commit that referenced this pull request Jan 6, 2019
@kt3k @ry
Implement console.groupCollapsed (#1452)
cae71ed 
This implementation of groupCollapsed is intentionally different
from the spec defined by whatwg. See the conversation in #1355
and #1363.
@kt3k
Copy link
Member

kt3k commented Jan 7, 2019

This PR has been landed as part of #1452.

@zhmushan
Copy link
Contributor Author

zhmushan commented Jan 7, 2019

This PR has been landed as part of #1452.

👌

@zhmushan zhmushan closed this Jan 7, 2019
@zhmushan zhmushan deleted the console_group branch January 7, 2019 05:19
@kt3k kt3k mentioned this pull request Jan 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justjavac justjavac justjavac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zhmushan @CLAassistant @ry @hayd @justjavac @kt3k