Handle Location header relative URI #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a29519
to
4f93841
Compare
ry
reviewed
Nov 29, 2018
src/http_util.rs
Outdated
| @@ -26,6 +26,37 @@ pub fn get_client() -> Client<Connector, hyper::Body> { | |||
| Client::builder().build(c) | |||
| } | |||
|
|
|||
| // Construct the next uri based on base uri and location header fragment | |||
| // https://tools.ietf.org/html/rfc3986#section-4.2 | |||
| fn maybe_uri_from_location(base_uri: &Uri, location: &str) -> Option<Uri> { | |||
There was a problem hiding this comment.
- I think it's better to call this
resolve_uri_from_location - Can you use triple slashes for the comments, so it shows up in rustdoc?
- Also please describe in the docs when the "None" case occurs.
There was a problem hiding this comment.
(We haven't been doing triple slash comments for Rust - but I will be trying to fix that in the future - as we move towards releasing a crate)
There was a problem hiding this comment.
Done. Removed the Option wrapper since it is actually not needed with current design.
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 30, 2018
- Allow async functions in REPL (denoland#1233) - Handle Location header relative URI (denoland#1240) - Add deno.readAll() (denoland#1234) - Add Process.output (denoland#1235) - Upgrade to TypeScript 3.2.1 - Upgrade crates: tokio 0.1.13, hyper 0.12.16, ring 0.13.5
Merged
ry
added a commit
that referenced
this pull request
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses 1st part of problem for #1239 (the location header in the sample given was
/[email protected]?module, not a full path)Locationheader that contains relative URIRefs:
https://tools.ietf.org/html/rfc7231#page-68
https://tools.ietf.org/html/rfc3986#section-4.2
https://tools.ietf.org/html/rfc3986#section-3.3