REPL unblock event loop AND fix REPL setTimeout fire problems #1233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1161 .
op_repl_readline
always blocking problem that breakssetTimeout
firesetTimeout
test/cc @hayd @cedric05
Also, though not fixed in this PR, there is one more issue I found that might need to be address later:
deno/src/resources.rs
Lines 335 to 345 in 89096c9
Since
let line = r.readline(&prompt)?;
is blocking, this might causeRESOURCE_TABLE.lock()
not released in REPL and blocks other resources reads and writes