Support request method and headers in fetch() #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
commented
Nov 14, 2018
|
@piscisaureus test added. |
Adds a general HttpHeader flatbuffer message for serializing requests and responses.
csmoe
reviewed
Nov 14, 2018
| const actual = new TextDecoder().decode(buf.bytes()); | ||
| const expected = [ | ||
| "POST /blah HTTP/1.1\r\n", | ||
| "hello: World\r\n", |
There was a problem hiding this comment.
Does it really lower-case the headers? :/
There was a problem hiding this comment.
It’s part of the Headers implementation. shrug
piscisaureus
approved these changes
Nov 15, 2018
ry
added a commit
to ry/deno
that referenced
this pull request
Nov 16, 2018
Changes since v0.1.12: - First pass at running subprocesses (denoland#1156) - Improve flag parsing (denoland#1200) - Improve fetch() (denoland#1194 denoland#1188 denoland#1102) - Support shebang (denoland#1197)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a general HttpHeader flatbuffer message for serializing requests
and responses.
Fixes #1133