Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at streaming bodies from fetch() #1102

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Conversation

ry
Copy link
Member

@ry ry commented Oct 26, 2018

No description provided.

@ry ry force-pushed the stream_fetch branch 3 times, most recently from 0ec68a8 to 8e8e852 Compare October 26, 2018 19:55
@ry ry requested a review from piscisaureus October 26, 2018 23:40
js/fetch.ts Show resolved Hide resolved
js/fetch.ts Outdated Show resolved Hide resolved
js/fetch.ts Outdated Show resolved Hide resolved
js/fetch.ts Outdated Show resolved Hide resolved
js/fetch.ts Show resolved Hide resolved
src/resources.rs Show resolved Hide resolved
@ry ry force-pushed the stream_fetch branch 2 times, most recently from fac4e8f to a181761 Compare October 29, 2018 23:22
@ry
Copy link
Member Author

ry commented Oct 29, 2018

@piscisaureus PTAL

js/fetch.ts Outdated Show resolved Hide resolved
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Also Buffer.readFrom in fetch() to buffer response.
@ry ry merged commit b157946 into denoland:master Nov 14, 2018
@ry ry deleted the stream_fetch branch November 14, 2018 05:44
ry added a commit to ry/deno that referenced this pull request Nov 16, 2018
Changes since v0.1.12:
- First pass at running subprocesses (denoland#1156)
- Improve flag parsing (denoland#1200)
- Improve fetch() (denoland#1194 denoland#1188 denoland#1102)
- Support shebang (denoland#1197)
@ry ry mentioned this pull request Nov 16, 2018
ry added a commit that referenced this pull request Nov 16, 2018
Changes since v0.1.12:
- First pass at running subprocesses (#1156)
- Improve flag parsing (#1200)
- Improve fetch() (#1194 #1188 #1102)
- Support shebang (#1197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants