Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions of tool wrappers #1218

Merged
merged 2 commits into from
Jun 1, 2023
Merged

update versions of tool wrappers #1218

merged 2 commits into from
Jun 1, 2023

Conversation

lldelisle
Copy link
Contributor

Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :

  • Does the PR contain new feature?
  • Does the PR contain bugfix?
  • Does the PR contain documentation changes?
  • Does the PR contain changes to the galaxy wrapper?

Adopt the version style of tools-iuc: deeptools version +galaxyN

Update deeptools version from 3.5.1 to 3.5.2

@lldelisle
Copy link
Contributor Author

@bgruening would you mind to merge this and deploy to toolshed?
There is a tool on toolshed which cannot work: https://toolshed.g2.bx.psu.edu/view/bgruening/deeptools_bigwig_average/9987ddd67710 (I was not expecting that the version of deeptools was changed without the macro of galaxy wrappers). Can we mark it as 'unusable'?

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please macro'fy the profile version and bump it to some more recent version please?

@lldelisle
Copy link
Contributor Author

@bgruening to avoid such issues in future, do you know an easy way with github actions that both version matches when PR to master?

@bgruening
Copy link
Member

Mh, we should always change it in the macro isn't it. Exception is the +galaxy version, that can be changed per tool if really needed. I will see if I can deprecate the tool once I have net

@bgruening bgruening merged commit 810c135 into deeptools:master Jun 1, 2023
6 checks passed
@lldelisle lldelisle deleted the galaxy_tools_update branch June 1, 2023 10:16
@lldelisle
Copy link
Contributor Author

Thanks. Please, let me know when you put them on toolshed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants