fix: CacheChecker filters syntax

[vedantnaik19]

Related Issues

• fixes Fix CacheChecker Component to use new filters internally #7892

Proposed Changes:

• Use new filter syntax in the CacheChecker component instead of legacy ones.

How did you test it?

• Existing unit tests

Notes for the reviewer

N/A

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[coveralls]

Pull Request Test Coverage Report for Build 9588121513

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 90.14%

---

Files with Coverage Reduction	New Missed Lines	%
document_stores/in_memory/document_store.py	1	97.87%

Totals
Change from base Build 9583192592:	-0.01%
Covered Lines:	6994
Relevant Lines:	7759

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9588140829

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 90.14%

---

Files with Coverage Reduction	New Missed Lines	%
document_stores/in_memory/document_store.py	1	97.87%

Totals
Change from base Build 9583192592:	-0.01%
Covered Lines:	6994
Relevant Lines:	7759

---

💛 - Coveralls

[shadeMe]

Thanks for the PR! Could you add the release note and a unit test?

[vedantnaik19]

Thanks for the PR! Could you add the release note and a unit test?

Hello 👋
I have added a release note now.
However, I am not sure if I should add another unit test, as there is an existing test which checks the functionality. 🤔

[silvanocerza]

Hello 👋 I have added a release note now. However, I am not sure if I should add another unit test, as there is an existing test which checks the functionality. 🤔

@vedantnaik19 the current test is not that great. Best thing would be to use a mocked Document Store and verify that filter_documents() is called with the correct filters syntax.

As of now it's indirectly testing InMemoryDocumentStore.filter_documents() and that's why we didn't notice it was using the old filters syntax.

[coveralls]

Pull Request Test Coverage Report for Build 9595378983

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 90.14%

---

Files with Coverage Reduction	New Missed Lines	%
document_stores/in_memory/document_store.py	1	97.87%

Totals
Change from base Build 9583192592:	-0.01%
Covered Lines:	6994
Relevant Lines:	7759

---

💛 - Coveralls

[vedantnaik19]

Hello 👋 I have added a release note now. However, I am not sure if I should add another unit test, as there is an existing test which checks the functionality. 🤔

@vedantnaik19 the current test is not that great. Best thing would be to use a mocked Document Store and verify that filter_documents() is called with the correct filters syntax.

As of now it's indirectly testing InMemoryDocumentStore.filter_documents() and that's why we didn't notice it was using the old filters syntax.

Hello 👋
I have added a test now. Please let me know if this is OK.
Also, thanks for your previous feedback @silvanocerza @shadeMe 🙌

[coveralls]

Pull Request Test Coverage Report for Build 9611011281

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 90.046%

---

Files with Coverage Reduction	New Missed Lines	%
document_stores/in_memory/document_store.py	1	97.87%

Totals
Change from base Build 9610765652:	-0.01%
Covered Lines:	6911
Relevant Lines:	7675

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9611018079

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 90.046%

---

Files with Coverage Reduction	New Missed Lines	%
document_stores/in_memory/document_store.py	1	97.87%

Totals
Change from base Build 9610765652:	-0.01%
Covered Lines:	6911
Relevant Lines:	7675

---

💛 - Coveralls

[silvanocerza]

Looks good, thanks!

Solved