fix: Prevent component pre-init hook from being called "recursively" #7894
+58
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
The pipeline deserialization callbacks make use of an internal hook to override the init parameters of components during the deserialization process. Prior to this PR, the hook would get invoked incorrectly under the following conditions:
This causes the hook to be invoked yet again but with the same callback, which is bound to the first component's name. We fix this by using an additional flag to detect if we're still executing the hook and exiting early.
How did you test it?
Unit test
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.