Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HuggingFaceAPIDocumentEmbedder #7485

Merged
merged 19 commits into from
Apr 8, 2024
Merged

feat: HuggingFaceAPIDocumentEmbedder #7485

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dec6cd0
add HuggingFaceAPITextEmbedder
anakin87 Apr 5, 2024
045fe1c
add HuggingFaceAPITextEmbedder
anakin87 Apr 5, 2024
fb21201
rm unneeded else
anakin87 Apr 5, 2024
3934b6e
wip
anakin87 Apr 5, 2024
14cedf4
small fixes
anakin87 Apr 5, 2024
eb80ecf
Merge branch 'hfapitextembedder' into hfapidocembedder
anakin87 Apr 5, 2024
77c56c1
deprecation; reno
anakin87 Apr 5, 2024
b806422
Apply suggestions from code review
anakin87 Apr 5, 2024
85a8d4b
make params mandatory
anakin87 Apr 5, 2024
9e5a249
Merge branch 'hfapidocembedder' of https://github.com/deepset-ai/hays…
anakin87 Apr 5, 2024
e467feb
changes requested
anakin87 Apr 5, 2024
78a6205
Merge branch 'main' into hfapitextembedder
anakin87 Apr 5, 2024
1fb6c37
Merge branch 'hfapitextembedder' into hfapidocembedder
anakin87 Apr 5, 2024
7aa1572
fix test
anakin87 Apr 5, 2024
2df1102
Merge branch 'hfapitextembedder' into hfapidocembedder
anakin87 Apr 5, 2024
45dc97f
fix test
anakin87 Apr 5, 2024
c0bd716
Merge branch 'main' into hfapitextembedder
anakin87 Apr 5, 2024
7d91a72
Merge branch 'hfapitextembedder' into hfapidocembedder
anakin87 Apr 5, 2024
251728d
Merge branch 'main' into hfapidocembedder
anakin87 Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rm unneeded else
  • Loading branch information
@anakin87
anakin87 committed Apr 5, 2024
commit fb21201a017fb1390b26d93224ad541e248f93e7
4 changes: 0 additions & 4 deletions haystack/components/embedders/hugging_face_api_text_embedder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,6 @@ def __init__(
if not is_valid_http_url(url):
raise ValueError(f"Invalid URL: {url}")
model_or_url = url
else:
raise ValueError(
f"Unsupported API type: {api_type}. Supported types are: {[e.value for e in HFEmbeddingAPIType]}"
)

self.api_type = api_type
self.api_params = api_params
Expand Down