Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HuggingFaceAPIDocumentEmbedder #7485

Merged
merged 19 commits into from
Apr 8, 2024
Merged

feat: HuggingFaceAPIDocumentEmbedder #7485

merged 19 commits into from
Apr 8, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Apr 5, 2024

Related Issues

Proposed Changes:

  • introduce a new better HuggingFaceAPIDocumentEmbedder
  • deprecate HuggingFaceTEIDocumentEmbedder

How did you test it?

CI, new tests, extensive manual tests: with HF Inference API, local TEI container and paid HF Inference Endpoint

Checklist

@anakin87 anakin87 requested review from a team as code owners April 5, 2024 10:23
@anakin87 anakin87 requested review from dfokina and shadeMe and removed request for a team April 5, 2024 10:23
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Apr 5, 2024
@anakin87 anakin87 requested a review from shadeMe April 5, 2024 14:28
Base automatically changed from hfapitextembedder to main April 8, 2024 12:22
@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Apr 8, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8600010381

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 89.842%

Files with Coverage Reduction New Missed Lines %
components/embedders/hugging_face_tei_document_embedder.py 1 98.53%
Totals Coverage Status
Change from base Build 8599965617: 0.1%
Covered Lines: 6023
Relevant Lines: 6704

💛 - Coveralls

@anakin87 anakin87 merged commit eff53a9 into main Apr 8, 2024
24 checks passed
@anakin87 anakin87 deleted the hfapidocembedder branch April 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants