Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pipeline - disable autoshow on Jupyter #7397

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

On Jupyter notebooks, the Pipeline is not automatically rendered as an image.
We use the textual repr by default.

extensive Colab notebook

Checklist

@github-actions github-actions bot added 2.x Related to Haystack v2.0 topic:core labels Mar 21, 2024
@github-actions github-actions bot added the type:documentation Improvements on the docs label Mar 21, 2024
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colab example works as expected 💯

@anakin87 anakin87 marked this pull request as ready for review March 21, 2024 09:57
@anakin87 anakin87 requested review from a team as code owners March 21, 2024 09:57
@anakin87 anakin87 requested review from dfokina and vblagoje and removed request for a team March 21, 2024 09:57
@coveralls
Copy link
Collaborator

coveralls commented Mar 21, 2024

Pull Request Test Coverage Report for Build 8372993968

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 89.257%

Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 23 93.7%
Totals Coverage Status
Change from base Build 8371861291: -0.006%
Covered Lines: 5409
Relevant Lines: 6060

💛 - Coveralls

@vblagoje
Copy link
Member

Wait, I liked this feature 😢 How do I use it again explicitly, just pipeline.show()?

@anakin87
Copy link
Member Author

Wait, I liked this feature 😢 How do I use it again explicitly, just pipeline.show()?

Yes! See the example notebook.

I'm just disabling the auto-show, which cluttered notebooks. (Requested in #7244)

Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with 😢

@anakin87 anakin87 merged commit 6e69d4f into main Mar 21, 2024
38 checks passed
@anakin87 anakin87 deleted the pipe-disable-autoshow branch March 21, 2024 11:55
silvanocerza pushed a commit that referenced this pull request Apr 8, 2024
* try

* fix docstring

* simplify tests

* add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add draw() method to trigger pipeline image visualization
4 participants