Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draw() method to trigger pipeline image visualization #7244

Closed
bilgeyucel opened this issue Feb 28, 2024 · 1 comment · Fixed by #7397
Closed

Add draw() method to trigger pipeline image visualization #7244

bilgeyucel opened this issue Feb 28, 2024 · 1 comment · Fixed by #7397
Assignees
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint topic:pipeline
Milestone

Comments

@bilgeyucel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The pipeline image shows up when the add_component and connect methods are called. This is sometimes problematic because:

  • The image takes up a lot of space
  • Sometimes, the image creation raises an error as the mermaid service can be unstable from time to time

Describe the solution you'd like
Change the behavior of pipeline images showing up by default and add show() method to visualize those images when required

Describe alternatives you've considered
Just change the default behavior and not provide a show() method (we already have draw() method to visualize the image)

Additional context
N/A

@bilgeyucel bilgeyucel added topic:pipeline 2.x Related to Haystack v2.0 labels Feb 28, 2024
@bilgeyucel bilgeyucel added this to the 2.0.0 milestone Feb 28, 2024
@masci masci modified the milestones: 2.0.0, 2.1.0 Mar 1, 2024
@masci masci added the P2 Medium priority, add to the next sprint if no P1 available label Mar 1, 2024
@masci
Copy link
Contributor

masci commented Mar 15, 2024

I think we just need to turn off this auto-show feature: https://github.com/deepset-ai/haystack/blob/main/haystack/core/pipeline/pipeline.py#L91-L94 - not sure I get what the difference would be between draw/show?

@masci masci added P1 High priority, add to the next sprint and removed P2 Medium priority, add to the next sprint if no P1 available labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint topic:pipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants