Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Improve PyPDFToDocument #7362

Merged
merged 8 commits into from
Mar 26, 2024
Merged

refactor!: Improve PyPDFToDocument #7362

merged 8 commits into from
Mar 26, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

Explained in the original issue.

Just a first draft.
If the approach is OK, I will add release notes

How did you test it?

CI, new tests

Checklist

@anakin87 anakin87 requested a review from a team as a code owner March 14, 2024 15:54
@anakin87 anakin87 requested review from julian-risch and silvanocerza and removed request for a team and julian-risch March 14, 2024 15:54
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Mar 14, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8419545663

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 97 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.3%) to 89.426%

Files with Coverage Reduction New Missed Lines %
components/generators/openai.py 3 96.1%
components/generators/chat/hugging_face_tgi.py 5 94.85%
components/generators/hugging_face_local.py 5 91.89%
components/generators/hugging_face_tgi.py 5 94.44%
components/converters/pypdf.py 6 92.0%
dataclasses/document.py 6 93.4%
components/generators/chat/openai.py 18 77.88%
core/pipeline/pipeline.py 23 93.7%
utils/hf.py 26 77.95%
Totals Coverage Status
Change from base Build 8278967162: 0.3%
Covered Lines: 5514
Relevant Lines: 6166

💛 - Coveralls

@anakin87 anakin87 requested a review from a team as a code owner March 25, 2024 11:46
@anakin87 anakin87 requested review from dfokina and removed request for a team March 25, 2024 11:46
@anakin87 anakin87 merged commit 6925e3a into main Mar 26, 2024
23 checks passed
@anakin87 anakin87 deleted the try-pypdf branch March 26, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PyPDFToDocument
3 participants